[Webkit-unassigned] [Bug 185246] AX: VoiceOver on macOS does not announce fieldset description from aria-describedby when focussing inputs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 17:35:38 PDT 2018


--- Comment #4 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 341621
  --> https://bugs.webkit.org/attachment.cgi?id=341621

View in context: https://bugs.webkit.org/attachment.cgi?id=341621&action=review

>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1448
>> +                return object.isFieldset() && !object.ariaDescribedByAttribute().isEmpty();
> does it matter if we check whether ariaDescribedByAttribute is empty here? if we try to try to append an empty string nothing will happen anyway right? and then we'll save a call to ariaDescribedByAttribute?

No I think we still need to check empty() in this case, since AccessibilityText doesn't check empty in construction and also baseAccessibilityHelpText doesn't check empty before return.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180531/e52cd991/attachment.html>

More information about the webkit-unassigned mailing list