[Webkit-unassigned] [Bug 185246] AX: VoiceOver on macOS does not announce fieldset description from aria-describedby when focussing inputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185246

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 341621
  --> https://bugs.webkit.org/attachment.cgi?id=341621
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341621&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1444
> +    else {

should this be an else if (isControl()

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1445
> +        // For controls, use their fieldset parent's described-by text if avaialble.

available

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1448
> +                return object.isFieldset() && !object.ariaDescribedByAttribute().isEmpty();

does it matter if we check whether ariaDescribedByAttribute is empty here? if we try to try to append an empty string nothing will happen anyway right? and then we'll save a call to ariaDescribedByAttribute?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180531/46ff3470/attachment-0001.html>