[Webkit-unassigned] [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185611

--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 340488
  --> https://bugs.webkit.org/attachment.cgi?id=340488
Address comments

View in context: https://bugs.webkit.org/attachment.cgi?id=340488&action=review

>> Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:95
>> +    ChildProcessProxy::getLaunchOptions(launchOptions);
> 
> This doesn't look correct either. I think the problem is that most of the child processes are calling connect(), which is virtual, in the constructor. The right fix might be to call connect from the create() methods after the object is constructed like WebProcessProxy does.

I'm sorry, this is indeed correct. platform impl is the one setting the processType, so it should go first. I still think it's weird to add a default to a switch where all options are handled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180525/181910bf/attachment-0001.html>