[Webkit-unassigned] [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185611

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com
 Attachment #340488|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #17 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 340488
  --> https://bugs.webkit.org/attachment.cgi?id=340488
Address comments

View in context: https://bugs.webkit.org/attachment.cgi?id=340488&action=review

> Source/WebKit/UIProcess/ChildProcessProxy.cpp:79
> +    default:
> +        ASSERT_NOT_REACHED();

I don't think this is the right fix, this should never happen, we are handling all possible values in the switch.

> Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:95
> -    ChildProcessProxy::getLaunchOptions(launchOptions);
>      platformGetLaunchOptions(launchOptions, m_pluginProcessAttributes);
> +    ChildProcessProxy::getLaunchOptions(launchOptions);

This doesn't look correct either. I think the problem is that most of the child processes are calling connect(), which is virtual, in the constructor. The right fix might be to call connect from the create() methods after the object is constructed like WebProcessProxy does.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180525/d9d095f5/attachment.html>