[Webkit-unassigned] [Bug 185925] OSBuildFetcher should respect maxRevision while finding OS builds to report.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185925

--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 341148
  --> https://bugs.webkit.org/attachment.cgi?id=341148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review

>> Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101
>> +                .filter((commit) => commit['order'] > minOrder && commit['order'] < maxOrder);
> 
> It seems that minOrder & maxOrder should be inclusive.

For minOrder, it should be exclusive as it is from 'last-reported' api and we don't want to report 'last-reported' again. For maxOrder, it could be both either way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180524/f597c263/attachment.html>