[Webkit-unassigned] [Bug 185925] OSBuildFetcher should respect maxRevision while finding OS builds to report.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 23 17:08:44 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=185925
Ryosuke Niwa <rniwa at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #341148|review? |review+
Flags| |
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 341148
--> https://bugs.webkit.org/attachment.cgi?id=341148
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review
> Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101
> - .filter((commit) => commit['order'] > minOrder);
> + .filter((commit) => commit['order'] > minOrder && commit['order'] < maxOrder);
It seems that minOrder & maxOrder should be inclusive.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180524/15f53f31/attachment.html>
More information about the webkit-unassigned
mailing list