[Webkit-unassigned] [Bug 180398] WebDriver: implement maximize, minimize and fullscreen window commands

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 23 06:31:51 PDT 2018


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 340956
  --> https://bugs.webkit.org/attachment.cgi?id=340956
Try to fix iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=340956&action=review

>> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:118
>> +        completeTimer.startOneShot(1_s);
> Seems like a good idea, though I've never had it flake out on macOS yet.

I think it's in the spec, but it doesn't say how long the timer should be, IIRC

>> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:190
> Why is this part guarded?

Because this code is only for the tests, it's a workaround for Xvfb, and tests are only built when developer mode is enabled.

>> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:196
>> +            gtk_window_move(window, screenRect.x(), screenRect.y());
> Should this be (0,0), or are the coordinates flipped somehow?

screenAvailableRect takes into account if there's a top panel at 0,0 for example.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180523/cc6f12f2/attachment.html>

More information about the webkit-unassigned mailing list