[Webkit-unassigned] [Bug 180398] WebDriver: implement maximize, minimize and fullscreen window commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180398

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340956|review?                     |review+
              Flags|                            |

--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 340956
  --> https://bugs.webkit.org/attachment.cgi?id=340956
Try to fix iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=340956&action=review

r=me except GObject parts in WebKitWebViewGTK.cpp, which I do not understand.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:118
> +        completeTimer.startOneShot(1_s);

Seems like a good idea, though I've never had it flake out on macOS yet.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:190
> +#if ENABLE(DEVELOPER_MODE)

Why is this part guarded?

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:196
> +            gtk_window_move(window, screenRect.x(), screenRect.y());

Should this be (0,0), or are the coordinates flipped somehow?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/a2ed2f7c/attachment.html>