[Webkit-unassigned] [Bug 185783] test262/Runner.pm: add unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 13:25:25 PDT 2018


--- Comment #10 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 341002
  --> https://bugs.webkit.org/attachment.cgi?id=341002

View in context: https://bugs.webkit.org/attachment.cgi?id=341002&action=review

> Tools/Scripts/test262/Runner.pm:273
> +    my @defaultharnessfiles = (

Nit: Should be camel cased.

> Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:48
> +my $ToolsPath = $ENV{'WEBKIT_LIBRARIES'};

Nit: Not a class, should start with a lower-case T

Also, I'm pretty sure this isn't the right way to do this.  Just tried applying your patch and running locally on my machine (via test-webkitperl) I see errors like this:
Can't exec "/Tools/Scripts/test262-runner": No such file or directory at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 132.

> Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:49
> +my $Runner = File::Spec->catfile($ToolsPath, 'Tools', 'Scripts', 'test262-runner');

Nit: Not a class, should start with a lower-case R

> Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:51
> +my $MockTest262 = abs_path("$Bin/fixtures");

Nit: Not a class, should start with a lower-case M

You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/d6617fdc/attachment.html>

More information about the webkit-unassigned mailing list