[Webkit-unassigned] [Bug 185783] test262/Runner.pm: add unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185783

--- Comment #9 from valerie <valerie at bocoup.com> ---
(In reply to Jonathan Bedard from comment #7)

> It seems to me, then, that either the harness files shouldn't live with the
> testing files or that we should fallback to the production harness files if
> there are not harness files in the testing directory.  This would allow you
> to eliminate the whole 'testing' directory idea.

I think that is the best idea and I've now implemented it -- patch uploaded. The environment variable is removed, and, if the harness files are not found within the supplied test262 directory, then the script will default to webkit's test262 directory.

The reason the harness files are alongside the test files is because Webkit's test262 directory matches the directory structure of the test262 git repo. If you have a checkout of the test262 repo, you can point the runner your local checkout with --t262 and it will run the tests (with the harness files) there.

Finally, the diff of Runner.pm might be a little confusing because I moved around some unrelated logic. I found it pretty obnoxious that the test262-results directory is not lazily created when running this script, so that directory is now lazily created with this patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/6d3081d8/attachment.html>