[Webkit-unassigned] [Bug 126907] [GTK] Hardcoded text color in input fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126907

--- Comment #33 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
Created attachment 340924

  --> https://bugs.webkit.org/attachment.cgi?id=340924&action=review

Example

(In reply to Michael Catanzaro from comment #31)
> (In reply to Carlos Eduardo Ramalho from comment #30)
> > I ran intro trouble with HighContrast theme which is now drawing light text with light
> > background.
> 
> The GTK+ developers are telling me that this should work, because the
> foreground color is black for HighContrast. Exactly which color are you
> using? I'm looking at
> https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-22/gtk/theme/HighContrast/
> _colors.scss.

Attached is an (ugly) example of getting color from after using  gtk_widget_path_new ().

Try running it with GTK_THEME=Adwaita or HighConstrastInverse and then with GTK_THEME=HighContrast: every theme gives the expected color except HighContrast.

One interesting thing is it happens only for Entries (try changing entry to button in gtk_widget_path_iter_set_object_name and check). So I dig in the scss files and found that comparing

https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-22/gtk/theme/Adwaita/_drawing.scss#L49

and 

https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-22/gtk/theme/HighContrast/_drawing.scss#L58

shows that in HighContrast it lacks "color:" in entries, so somehow it gets white.

Simply adding "color: $fg_color" solved it for me. Can the GTK developers confirm this is the case?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180521/7802d982/attachment.html>