[Webkit-unassigned] [Bug 126907] [GTK] Hardcoded text color in input fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126907

--- Comment #32 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Company the problem is this:
        GTK uses white as the default foreground color
        and we use proper css inheritance
        entry is set to inherit its foreground color in HC
        so in Webkit, it has no parent, so it inherits the default white
        and in a regular GTK app
        it's ultimately contained in something toplevel
        and all GTK toplevels set the .background class
        so the entry's color ends up being set by https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-22/gtk/theme/HighContrast/gtk-contained.css#L38
...
        so my suggested fix is creating a "window.background" base gadget that all other gadgets are made children of
...
        that constructor should create some "Default gadget" that is a window + webview
...
         window.background + webview
         the window.background is the important part, the webview one would be nice for themers


So the place to do that would be in the RenderThemeGadget constructor. There are two places we currently use gtk_widget_path_new(). Those would need to instead use a default base widget path. "window.background" is what Company thinks would fix the text color. And then, optionally, "webview" to allow theme developers to provide custom styling for WebKit (a totally separate issue, but this has been requested before and now would be the perfect time to add it). If you're lucky, and that actually works, then we can say it was simple. :P

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180521/ab268328/attachment.html>