[Webkit-unassigned] [Bug 185511] [GTK] Implement ImageBuffer::toBGRAData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185511

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340088|                            |review?, commit-queue?
              Flags|                            |

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 340088

  --> https://bugs.webkit.org/attachment.cgi?id=340088&action=review

(In reply to Michael Catanzaro from comment #3)

> Comment on attachment 340087 [details]
> Minor typo fix since previous version.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340087&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        [GTK] Implement ImageBuffer::toBGRAData
> 
> The commit title doesn't belong here, you already have it properly up at the
> top.

Not sure how that happened, I just used prepareChangeLog, anyway Fixed.

> > Source/WebCore/platform/graphics/ImageBuffer.cpp:105
> > +#if USE(CG) && !PLATFORM(GTK)
> 
> Move the CG implementation to ImageBufferCG.cpp, then this condition can
> become #if !USE(CG) && !PLATFORM(GTK).

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180510/6eb45a32/attachment.html>