[Webkit-unassigned] [Bug 185511] [GTK] Implement ImageBuffer::toBGRAData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 06:44:52 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |mcatanzaro at igalia.com
 Attachment #340087|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340087
  --> https://bugs.webkit.org/attachment.cgi?id=340087
Minor typo fix since previous version.

View in context: https://bugs.webkit.org/attachment.cgi?id=340087&action=review

> Source/WebCore/ChangeLog:8
> +        [GTK] Implement ImageBuffer::toBGRAData

The commit title doesn't belong here, you already have it properly up at the top.

> Source/WebCore/platform/graphics/ImageBuffer.cpp:105
> +#if USE(CG) && !PLATFORM(GTK)

Move the CG implementation to ImageBufferCG.cpp, then this condition can become #if !USE(CG) && !PLATFORM(GTK).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180510/196a1b8c/attachment-0001.html>

More information about the webkit-unassigned mailing list