[Webkit-unassigned] [Bug 182869] [WinCairo] Add WKView and WKAPI for wincairo
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 28 15:55:44 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=182869
Alex Christensen <achristensen at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #335295|review? |review-
Flags| |
--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 335295
--> https://bugs.webkit.org/attachment.cgi?id=335295
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=335295&action=review
This is adding a file that doesn't compile. Let's not.
> Source/WebKit/UIProcess/API/C/win/WKAPICastWin.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.
If this is resurrecting old code, please indicate the initial commit this came from.
> Source/WebKit/UIProcess/API/C/win/WKAPICastWin.h:38
> +WK_ADD_API_MAPPING(WKViewRef, WebView)
Is WebView correct? I think we might want something more like WebPageProxy here.
> Source/WebKit/UIProcess/API/C/win/WKView.cpp:32
> +#include "WebView.h"
WebView.h doesn't exist in modern WebKit. Does this compile?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180328/9364641b/attachment-0001.html>
More information about the webkit-unassigned
mailing list