[Webkit-unassigned] [Bug 182869] [WinCairo] Add WKView and WKAPI for wincairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182869

--- Comment #6 from Yousuke Kimoto <Yousuke.Kimoto at sony.com> ---
Thank you for your review.

(In reply to Alex Christensen from comment #4)
> Comment on attachment 334997 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334997&action=review
> 
> > Source/WebKit/UIProcess/API/C/win/WKView.cpp:65
> > +void WKViewSetIsInWindow(WKViewRef viewRef, bool isInWindow)
> > +{
> > +    notImplemented();
> > +}
> 
> Let's not add unimplemented API.
Fixed. 

> > Source/WebKit/UIProcess/API/C/win/WKView.cpp:112
> > +void WKViewSetDrawsTransparentBackground(WKViewRef viewRef, bool drawsTransparentBackground)
> > +{
> > +}
> 
> ditto.
> > Source/WebKit/UIProcess/API/C/win/WKView.cpp:117
> > +bool WKViewDrawsTransparentBackground(WKViewRef viewRef)
> > +{
> > +    return false;
> > +}
> 
> This is also basically unimplemented.
Those two APIs are not used for now, so they were just removed.

> > Source/WebKit/UIProcess/API/C/win/WKView.h:76
> > +    WK_EXPORT void WKViewSetInitialFocus(WKViewRef view, bool forward);
> 
> forward is probably the wrong name here.
"isForward" is used instead by mimicking WKViewSetIsInWindow()'s boolean variable name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180308/c18152be/attachment.html>