[Webkit-unassigned] [Bug 183796] Lint web-platform-tests changes with the wpt linter before exporting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 11:46:23 PDT 2018


--- Comment #14 from youenn fablet <youennf at gmail.com> ---
> >> Tools/Scripts/webkitpy/w3c/wpt_linter.py:31
> >> +    calls = []
> > 
> > Probably not needed.
> When I remove this line I get the following linter error:
> ERROR: Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py:142: 
> [TestExporterTest.test_export] Instance of 'WPTLinter' has no 'calls' member
> (but some types could not be inferred)  [pylint/E1103] [5]
> Here the linter wrong, since the reference to `calls` on line 142 in
> test_exporter_unittest.py is actually an instance of MockWPTLinter but I
> wasn't able to figure out a way to signal that to the linter and I'm not
> sure why the other Mock objects used in test_exporter_unittest.py also don't
> trigger the same volition.

It might be that the linter has been improved since the time we committed the changes?
Maybe you could keep the Mock linter in a variable and check its calls member directly instead of accessing through the exporter.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180323/c7aba747/attachment-0001.html>

More information about the webkit-unassigned mailing list