[Webkit-unassigned] [Bug 183796] Lint web-platform-tests changes with the wpt linter before exporting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 11:31:30 PDT 2018


--- Comment #13 from Brendan McLoughlin <brendan at bocoup.com> ---
Comment on attachment 336294
  --> https://bugs.webkit.org/attachment.cgi?id=336294

View in context: https://bugs.webkit.org/attachment.cgi?id=336294&action=review

>> Tools/Scripts/webkitpy/w3c/wpt_linter.py:31
>> +    calls = []
> Probably not needed.

When I remove this line I get the following linter error:

ERROR: Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py:142:  [TestExporterTest.test_export] Instance of 'WPTLinter' has no 'calls' member (but some types could not be inferred)  [pylint/E1103] [5]

Here the linter wrong, since the reference to `calls` on line 142 in test_exporter_unittest.py is actually an instance of MockWPTLinter but I wasn't able to figure out a way to signal that to the linter and I'm not sure why the other Mock objects used in test_exporter_unittest.py also don't trigger the same volition.

>> Tools/Scripts/webkitpy/w3c/wpt_linter.py:37
>> +        cmd = [self.repository_directory + '/wpt', 'lint']
> We usually use webkitpy filesystem.join to concat paths appropriately.
> Maybe you could pass the filesystem to the constructor and build the path there.

Will do.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180323/ded74c1a/attachment.html>

More information about the webkit-unassigned mailing list