[Webkit-unassigned] [Bug 183796] Lint web-platform-tests changes with the wpt linter before exporting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 14:24:08 PDT 2018


youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #336294|review?                     |review+
              Flags|                            |

--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 336294
  --> https://bugs.webkit.org/attachment.cgi?id=336294

View in context: https://bugs.webkit.org/attachment.cgi?id=336294&action=review

> Tools/Scripts/webkitpy/w3c/wpt_linter.py:31
> +    calls = []

Probably not needed.

> Tools/Scripts/webkitpy/w3c/wpt_linter.py:37
> +        cmd = [self.repository_directory + '/wpt', 'lint']

We usually use webkitpy filesystem.join to concat paths appropriately.
Maybe you could pass the filesystem to the constructor and build the path there.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180322/74d15a00/attachment.html>

More information about the webkit-unassigned mailing list