[Webkit-unassigned] [Bug 183386] LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html fails with async policy delegate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183386

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #335152|review?                     |review-
              Flags|                            |

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 335152
  --> https://bugs.webkit.org/attachment.cgi?id=335152
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=335152&action=review

> Source/WebKit/ChangeLog:8
> +				Add WKFrameLoadState enum to match FrameLoaderState.

indentation problem.

> Source/WebCore/history/PageCache.cpp:81
> +    if (!frame.isMainFrame() && (frameLoader.state() == FrameStateAsyncDecidePolicy || frameLoader.state() == FrameStateProvisional)) {

Instead of adding a new state, would it be possible to rely on frameLoader.policyChecker().delegateIsDecidingNavigationPolicy() ?

> LayoutTests/ChangeLog:9
> +				Update tests to test the async case.

indentation problem.

> LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html:10
> +    if (testRunner.setShouldDecideNavigationPolicyAfterDelay)

Please copy the test before adding those lines so we keep both versions of the test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180306/61eebf26/attachment.html>