[Webkit-unassigned] [Bug 183285] [GTK] Switch to use always complex text code path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183285

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 334892 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334892&action=review
> 
> > Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp:96
> > +    const char* forceComplexText = getenv("WEBKIT_FORCE_COMPLEX_TEXT");
> 
> The semantics of this are backwards.
> 
> Should be either WEBKIT_FORCE_SIMPLE_TEXT=1 or WEBKIT_DISABLE_COMPLEX_TEXT=1.

This doesn't force simple text and it doesn't disable complex text either. It either forces complex text or leaves the current auto where complex or simple is used depending on the context.

> Let's not check for 0.

I don't see why.

> > Tools/ChangeLog:8
> > +        Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
> 
> I don't think this is a great idea... now we are not testing the code that
> users are actually running anymore. I would do a rebaseline at the same time.

The default is auto, so complex test is still tested when required. Most of the changes that we will have to rebaseline are in text that doesn't affect the test at all, like text explaining what the test does, for example. The idea is to try it our during the next release cycle in the unstable releases, and once we make a decision we do the rebaseline. I don't want to waste the time doing a huge rebaseline to roll out the patch tomorrow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180302/c3185f61/attachment-0001.html>