[Webkit-unassigned] [Bug 183285] [GTK] Switch to use always complex text code path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183285

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334892
  --> https://bugs.webkit.org/attachment.cgi?id=334892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334892&action=review

> Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp:96
> +    const char* forceComplexText = getenv("WEBKIT_FORCE_COMPLEX_TEXT");

The semantics of this are backwards.

Should be either WEBKIT_FORCE_SIMPLE_TEXT=1 or WEBKIT_DISABLE_COMPLEX_TEXT=1.

Let's not check for 0.

> Tools/ChangeLog:8
> +        Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.

I don't think this is a great idea... now we are not testing the code that users are actually running anymore. I would do a rebaseline at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180302/355430e1/attachment.html>