[Webkit-unassigned] [Bug 187167] [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 30 14:04:25 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=187167

--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Fujii Hironori from comment #2)
> > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:233
> > +    SetWindowText(thisWindow.m_urlBarWnd, urlString.data());
> 
> Why did you replace c_str with data? Windows API expects a null-terminated
> string.

Note that for std::string, c_str() and data() are equivalent since C++ 11 (i.e. data() is now guaranteed to be null-terminated).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180630/5325822a/attachment-0001.html>


More information about the webkit-unassigned mailing list