[Webkit-unassigned] [Bug 187167] [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187167

Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andersca at apple.com

--- Comment #6 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 343896
  --> https://bugs.webkit.org/attachment.cgi?id=343896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343896&action=review

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:62
> -    return adoptWK(WKStringCreateWithUTF8CString(utf8.c_str()));
> +    return adoptWK(WKStringCreateWithUTF8CString(utf8.data()));

Pretty sure WKStringCreateWithUTF8CString expects a null terminated string.

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:69
> -    return adoptWK(WKURLCreateWithUTF8CString(utf8.c_str()));
> +    return adoptWK(WKURLCreateWithUTF8CString(utf8.data()));

Same here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180630/937e16cf/attachment-0001.html>