[Webkit-unassigned] [Bug 187221] Port WTF to OS(FUCHSIA)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187221

--- Comment #3 from Adam Barth <abarth at webkit.org> ---
> r=me with nits.

Thanks!

> > Source/WTF/wtf/FastMalloc.cpp:366
> > +#elif HAVE(RESOURCE_H)
> 
> Can we have an implementation for Fuchsia?
> If we can implement it (but if it is a bit complicated for this patch),
> adding FIXME here is desirable.

We removed resource.h from our libc in https://fuchsia.googlesource.com/zircon/+/67fec6dc8ea9285fb54f9bc741be63218439eda5%5E%21/

Apparently, the concepts expressed in that header don't map well to what we have planned in this area.  For example, Fuchsia doesn't track resource limits at process level.  Instead, resource usage is tracked at the job level to handle modern multiprocess applications.  (A job is a container for processes and other jobs.)

> > Source/WTF/wtf/RandomDevice.cpp:33
> > +#if !OS(DARWIN) && !OS(FUCHSIA) && OS(UNIX)
> 
> We should have `OS(FUCHSIA)` guard in RandomDevice.h too not to have m_fd.

Good idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180630/6980ff69/attachment-0001.html>