[Webkit-unassigned] [Bug 187221] Port WTF to OS(FUCHSIA)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187221

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344017|review?                     |review+
              Flags|                            |

--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 344017
  --> https://bugs.webkit.org/attachment.cgi?id=344017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344017&action=review

r=me with nits.

> Source/WTF/wtf/FastMalloc.cpp:366
> +#elif HAVE(RESOURCE_H)

Can we have an implementation for Fuchsia?
If we can implement it (but if it is a bit complicated for this patch), adding FIXME here is desirable.

> Source/WTF/wtf/RandomDevice.cpp:33
> +#if !OS(DARWIN) && !OS(FUCHSIA) && OS(UNIX)

We should have `OS(FUCHSIA)` guard in RandomDevice.h too not to have m_fd.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180630/8453ae4a/attachment.html>