[Webkit-unassigned] [Bug 186841] [WPE] Pass the backend library name as command line parameter to the web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186841

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Adrian Perez from comment #7)
> Comment on attachment 343490 [details]
> WIP
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343490&action=review
> 
> Looking good overall, just a couple of small comments below :-)
> 
> > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:105
> > +        wpeBackendLibraryParameter.reset(g_strdup_printf("--backend-library=%s", wpe_loader_get_loaded_implementation_library_name()));
> 
> Probably it's just fine to remove the “--backend-library=” prefix.

Yes, probably, I'm trying to avoid passing other stuff to wpe loader if we mess it up with the order of the arguments.

> > Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp:71
> > +            if (!strncmp(argv[4], "--backend-library=", parameterLength))
> 
> Ditto.
> 
> > Tools/wpe/backends/ViewBackend.cpp:39
> > +    wpe_loader_init("libWPEBackend-fdo-0.1.so");
> 
> Maybe it would be good to construct the backend library name to load with:
> 
>   GUniquePtr<char>
> fdoBackendName(g_strdup_printf("libWPEBackend-fdo-%i.%i.so"),
>                                                   WPE_BACKEND_MAJOR_VERSION,
>                                                  
> WPE_BACKEND_MINOR_VERSION));
>   wpe_loader_init(fdoBackendName.get());
> 
> This way we ensure that a backend implementation which is API/ABI-compatible
> with the version of libWPEBackend that WPE WebKit is being built against.
> (Also it's one place less to manually change strings when versions change.)

That doesn't work this way, you are mixing the project version with the library version. libWPEBackend-fdo-0.1.so will always be API/ABI compatible, it's actually a symlink to the latest version of the library. That 0.1 isn't going to change when we release version 0.2, for example, because that's not the project version, but the API version. If we make a new release that breaks the API/ABI then we will bump the API version, and we will have to update it manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180626/aa5b99ac/attachment.html>