[Webkit-unassigned] [Bug 186841] [WPE] Pass the backend library name as command line parameter to the web process

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 25 06:58:20 PDT 2018


--- Comment #7 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 343490
  --> https://bugs.webkit.org/attachment.cgi?id=343490

View in context: https://bugs.webkit.org/attachment.cgi?id=343490&action=review

Looking good overall, just a couple of small comments below :-)

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:105
> +        wpeBackendLibraryParameter.reset(g_strdup_printf("--backend-library=%s", wpe_loader_get_loaded_implementation_library_name()));

Probably it's just fine to remove the “--backend-library=” prefix.

> Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp:71
> +            if (!strncmp(argv[4], "--backend-library=", parameterLength))


> Tools/wpe/backends/ViewBackend.cpp:39
> +    wpe_loader_init("libWPEBackend-fdo-0.1.so");

Maybe it would be good to construct the backend library name to load with:

  GUniquePtr<char> fdoBackendName(g_strdup_printf("libWPEBackend-fdo-%i.%i.so"),

This way we ensure that a backend implementation which is API/ABI-compatible
with the version of libWPEBackend that WPE WebKit is being built against.
(Also it's one place less to manually change strings when versions change.)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180625/3f6494d1/attachment.html>

More information about the webkit-unassigned mailing list