[Webkit-unassigned] [Bug 186841] [WPE] Pass the backend library name as command line parameter to the web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186841

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Zan Dobersek from comment #2)
> Comment on attachment 343145 [details]
> WIP
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343145&action=review
> 
> > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:139
> > +    if (m_launchOptions.processType == ProcessLauncher::ProcessType::Web) {
> >          argv[i++] = wpeSocket.get();
> > +        if (wpeBackendLibraryParameter)
> > +            argv[i++] = wpeBackendLibraryParameter.get();
> > +    }
> 
> IMO the backend library name should be provided unconditionally. That means
> wpe_loader_get_loaded_library_name() would always return the appropriate
> library name.

But we can't know if the application called wpe_loader_init() at this point, and would break if using a previous version of WPEBackend. Actually, this patch is bumping the requirement, unless we add a way to make it conditional at build type.

> I would also reorganize the WebProcess argument list:
> $ WPEWebProcess <library.so> <wpe-fd> <wk-fd>

We can't do that, process and connection ids are handled by common code in ChildProcessMainBase::parseCommandLine(), so they need to be first. I don't think this is important anyway, since the web process is not expected to be launched by the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180625/d7af401a/attachment-0001.html>