[Webkit-unassigned] [Bug 186841] [WPE] Pass the backend library name as command line parameter to the web process

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 24 00:14:30 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=186841

--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 343145
  --> https://bugs.webkit.org/attachment.cgi?id=343145
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=343145&action=review

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:139
> +    if (m_launchOptions.processType == ProcessLauncher::ProcessType::Web) {
>          argv[i++] = wpeSocket.get();
> +        if (wpeBackendLibraryParameter)
> +            argv[i++] = wpeBackendLibraryParameter.get();
> +    }

IMO the backend library name should be provided unconditionally. That means wpe_loader_get_loaded_library_name() would always return the appropriate library name.

I would also reorganize the WebProcess argument list:
$ WPEWebProcess <library.so> <wpe-fd> <wk-fd>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180624/f07f2ce6/attachment.html>


More information about the webkit-unassigned mailing list