[Webkit-unassigned] [Bug 126907] [GTK] Hardcoded text color in input fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126907

--- Comment #76 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
(In reply to Michael Catanzaro from comment #75)
> Hmm, what does this change do? Why is it appropriate to adjust text field
> style only if shouldHaveSpinButton is true? This seems unlikely to be
> correct. I see the GTK-specific code was already performing this check, but
> I'm not sure why, and I'm not sure why it should be moved into
> cross-platform code.

Because it was added there in the first place to enforce drawing spin buttons even if the page has styled the text input. It was landed in r219332 to fix problems with the spinbuttons appearing over the input value.

Calling it unconditionally would force GTK styling (that now also sets the input colors) even when the input is styled.

I agree that it seems odd. Maybe it should be refactored to its own new function (adjustNumberInputStyle ?). It behaves correctly the same way it was before (at least does not break layout tests any more) but I'll probably have to change this again when solving bug 175067. If you think it looks ugly I can refactor it here already.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180619/55103b52/attachment-0001.html>