[Webkit-unassigned] [Bug 126907] [GTK] Hardcoded text color in input fields

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 09:42:10 PDT 2018


--- Comment #75 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 343018
  --> https://bugs.webkit.org/attachment.cgi?id=343018

View in context: https://bugs.webkit.org/attachment.cgi?id=343018&action=review

> Source/WebCore/platform/gtk/RenderThemeGadget.cpp:28
>  #include "RenderThemeGadget.h"
> +#include <mutex>

There should be a blank line before including <mutex>. I'm surprised the style bot didn't complain.

> Source/WebCore/rendering/RenderTheme.cpp:99
>          case TextFieldPart:
> -            adjustTextFieldStyle(styleResolver, style, element);
> +            if (is<HTMLInputElement>(element) && shouldHaveSpinButton(downcast<HTMLInputElement>(*element)))
> +                adjustTextFieldStyle(styleResolver, style, element);
>              FALLTHROUGH;

Hmm, what does this change do? Why is it appropriate to adjust text field style only if shouldHaveSpinButton is true? This seems unlikely to be correct. I see the GTK-specific code was already performing this check, but I'm not sure why, and I'm not sure why it should be moved into cross-platform code.

Other than that, the patch looks fine to me, but Carlos Garcia should review it because I don't understand most of it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180619/f2012b7f/attachment.html>

More information about the webkit-unassigned mailing list