[Webkit-unassigned] [Bug 186189] Crash in WebAnimation::runPendingPlayTask

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186189

--- Comment #19 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #18)
> (In reply to Carlos Garcia Campos from comment #17)
> > Why? 
> 
> So we can solve this bug and move on.
> 
> > The important thing here is not making a test pass but fixing the bug.
> 
> Your patch breaks the test. Neither of us is going to debug it, and
> obviously Antoine is not going to give r+. So if we want to land this, we
> should try a smaller change.

I debugged it, and explained my conclusions in comment #13. I don't want to make the test pass, I want to fix the bug. I'm not sure the test is correct.

> > Why are you so sure the test is correct?
> 
> I'm not.
> 
> > I can't because I'm not familiar with web notifications code nor the tests.
> 
> I assume you meant the animations code. My suggested change was very simple,
> only changing just enough to avoid the immediate crash. It should also fix
> this bug. If it works and avoids breaking the test, then we can move on.
> 
> Alternatively, if you could mention what test or website you are using to
> reproduce this crash, then someone else could take a look.

It happens a lot with github and w3c pages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180617/6cd453dd/attachment-0001.html>