[Webkit-unassigned] [Bug 186189] Crash in WebAnimation::runPendingPlayTask

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 16 09:24:17 PDT 2018


--- Comment #18 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #17)
> Why? 

So we can solve this bug and move on.

> The important thing here is not making a test pass but fixing the bug.

Your patch breaks the test. Neither of us is going to debug it, and obviously Antoine is not going to give r+. So if we want to land this, we should try a smaller change.

> Why are you so sure the test is correct?

I'm not.

> I can't because I'm not familiar with web notifications code nor the tests.

I assume you meant the animations code. My suggested change was very simple, only changing just enough to avoid the immediate crash. It should also fix this bug. If it works and avoids breaking the test, then we can move on.

Alternatively, if you could mention what test or website you are using to reproduce this crash, then someone else could take a look.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180616/af9bc498/attachment-0001.html>

More information about the webkit-unassigned mailing list