[Webkit-unassigned] [Bug 186219] [GTK] Correct behavior for dark themes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 05:14:00 PDT 2018


--- Comment #3 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
(In reply to Michael Catanzaro from comment #1)
> Carlos Garcia's comment in bug #118234 might be relevant:
> (In reply to Carlos Garcia Campos from comment #12)
> > I think we need to implement RenderTheme::isControlStyled() properly to
> > decide whether to apply native style or not.

I've been doing a few tests on this and here some notes:

The return of isControlStyled() impacts whether the adjustXyzStyle() methods are called AND paintXyz() (though it's not coded in RenderTheme, but in RenderBox checking for style.appearance()).

The adjustXyzStyle() basically set theme styles for the foreground (which is always drawn by the engine) and the paintXyz() methods draw the background directly to the cairo context via GTK foreign drawing (meaning basically background-color and rounded borders from GTK)

Checking if the color was modified in isControlStyled results in the background also not being drawn. This already happens if the background is changed via CSS as we don't the rounded border in some tests.

The difference is that if one sets the color now, we don't customize the background either. This is expected, expect I don't like having the inputs not rounded when the color is set :(

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180614/3584cdaf/attachment.html>

More information about the webkit-unassigned mailing list