[Webkit-unassigned] [Bug 186151] [Datalist] Allow TextFieldInputType to show and hide suggestions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186151

--- Comment #12 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Tim Horton from comment #11)
> Comment on attachment 342186 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342186&action=review
> 
> >>> Source/WebCore/html/TextFieldInputType.cpp:568
> >>> +#endif
> >> 
> >> How does this work? If the control theme doesn’t support the UI for suggestion lists, how does this patch make it work?
> > 
> > The UI for suggestions will be the same for the TextFieldInputTypes, and all TextFieldInputTypes support showing suggestions. The UI itself will be added in the next patch. 
> > 
> > Range and color inputs will require different UI, as we can't simply show a dropdown list of values. For that reason, no changes have been made to their methods at this time.
> 
> But themeSupportsDataListUI returns false when handed a TextFieldInputType,
> despite "all TextFieldInputTypes support showing suggestions”? That seems
> odd. And if it’s not true, you wouldn’t need this change.

I would eventually like to remove themeSupportsDataListUI. It currently returns false as we have no datalist support, but once finished, support will be determined by the specification.

Each input type can override shouldRespectListAttribute on it's own as necessary, since respecting the attribute is dependent on the type of input. The method needs to return true for us to be able to obtain the datalist element associated with the input.

A list of input types that support the list attribute can be found here: https://www.w3.org/TR/html50/forms.html#the-input-element. Once full support has been added, all of those types should have shouldRespectListAttribute return true.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180608/df59ecbe/attachment.html>