[Webkit-unassigned] [Bug 186151] [Datalist] Allow TextFieldInputType to show and hide suggestions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186151

--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 342186
  --> https://bugs.webkit.org/attachment.cgi?id=342186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342186&action=review

>>> Source/WebCore/html/TextFieldInputType.cpp:568
>>> +#endif
>> 
>> How does this work? If the control theme doesn’t support the UI for suggestion lists, how does this patch make it work?
> 
> The UI for suggestions will be the same for the TextFieldInputTypes, and all TextFieldInputTypes support showing suggestions. The UI itself will be added in the next patch. 
> 
> Range and color inputs will require different UI, as we can't simply show a dropdown list of values. For that reason, no changes have been made to their methods at this time.

But themeSupportsDataListUI returns false when handed a TextFieldInputType, despite "all TextFieldInputTypes support showing suggestions”? That seems odd. And if it’s not true, you wouldn’t need this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180608/f02f4531/attachment.html>