[Webkit-unassigned] [Bug 187741] [Datalist] Add button to TextFieldInputs with a datalist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187741

--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 345689
  --> https://bugs.webkit.org/attachment.cgi?id=345689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345689&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:264
> +    RefPtr<WebCore::Image> image = WebCore::Image::loadPlatformResource("ListButtonArrow");

You need a 2x version of this asset, and need to figure out how to load that correctly.

> Source/WebCore/rendering/RenderThemeMac.mm:1105
> +    // Margin to place button at end of input

Comments should be complete sentences and have punctuation.

> Source/WebCore/rendering/RenderThemeMac.mm:2363
> +NSCell* RenderThemeMac::listButton() const

Star's on the wrong side.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180726/c84108b8/attachment-0001.html>