[Webkit-unassigned] [Bug 187741] [Datalist] Add button to TextFieldInputs with a datalist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187741

--- Comment #10 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Tim Horton from comment #8)
> Comment on attachment 345253 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345253&action=review
>
> > Source/WebCore/rendering/RenderThemeMac.mm:226
> > +    if ([self userInterfaceLayoutDirection] == NSUserInterfaceLayoutDirectionRightToLeft) {
> 
> Does something really propagate UILayoutDirection into here!?

The UserInterfaceLayoutDirection is set in RenderThemeMac::paintListButtonForInput.

> > Source/WebCore/rendering/RenderThemeMac.mm:1085
> > +    NSRect listButtonFrame = NSMakeRect(r.maxX() - 16, r.y(), 16, r.height());
> 
> What’s this random 16? Would be nice to have a named constant.

It's the width of the button. I put it in a constant.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180724/0dc30d3f/attachment-0001.html>