[Webkit-unassigned] [Bug 186531] [Datalist][macOS] Add suggestions UI for TextFieldInputTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186531

--- Comment #29 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Tim Horton from comment #28)
> Comment on attachment 345106 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345106&action=review
> 
> > Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.h:53
> > +    NSView *m_view;
> 
> What's the lifetime of m_view vs. WebDataListSuggestionsDropdownMac? Is it
> OK that this is a raw pointer?

The suggestions view is destroyed each time it is hidden, so m_view (the WKWebView) should outlast WebDataListSuggestionsDropdownMac in most instances. If for some reason the WKWebView is destroyed while the suggestions view is still showing, WebPageProxy::close() will destroy the instance of WebDataListSuggestionsDropdownMac.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180716/47bdacbb/attachment.html>