[Webkit-unassigned] [Bug 186531] [Datalist][macOS] Add suggestions UI for TextFieldInputTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186531

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345106|review?                     |review+
              Flags|                            |

--- Comment #28 from Tim Horton <thorton at apple.com> ---
Comment on attachment 345106
  --> https://bugs.webkit.org/attachment.cgi?id=345106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345106&action=review

> Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.h:53
> +    NSView *m_view;

What's the lifetime of m_view vs. WebDataListSuggestionsDropdownMac? Is it OK that this is a raw pointer?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180716/04e8cabe/attachment.html>