[Webkit-unassigned] [Bug 187415] [WinCairo] Support display of webinspector ui on non-legacy minibrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 9 11:38:45 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=187415

--- Comment #10 from Stephan Szabo <stephan.szabo at sony.com> ---
Comment on attachment 344483
  --> https://bugs.webkit.org/attachment.cgi?id=344483
Initial WebInspector UI bits for non-legacy wincairo

View in context: https://bugs.webkit.org/attachment.cgi?id=344483&action=review

>> Source/WebKit/UIProcess/win/WebInspectorMessageListener.cpp:44
>> +            auto windowPos = reinterpret_cast<WINDOWPOS*>(lParam);
> 
> This function can be simplified by using *reinterpret_cast<WINDOWPOS*>(lParam).

I'm not sure what you mean here. We're actually modifying the WINDOWPOS pointed to by lParam in order to change the resulting size, so I don't think that using *reinterpret_cast<WINDOWPOS*>(lParam) will do what we want.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180709/9795e2d5/attachment.html>


More information about the webkit-unassigned mailing list