[Webkit-unassigned] [Bug 187415] [WinCairo] Support display of webinspector ui on non-legacy minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187415

--- Comment #9 from Stephan Szabo <stephan.szabo at sony.com> ---
Comment on attachment 344483
  --> https://bugs.webkit.org/attachment.cgi?id=344483
Initial WebInspector UI bits for non-legacy wincairo

View in context: https://bugs.webkit.org/attachment.cgi?id=344483&action=review

>> Source/WebKit/PlatformWin.cmake:53
>> +    UIProcess/win/WebInspectorMessageListener.cpp
> 
> The original implementaion had handled WM_WINDOWPOSCHANGING in WebInspectorProxy.
> Why do you want to add a new file?

I'd thought it might be harder to sell a platform specific inheritance change in WebInspectorProxy for Windows than to put it in its own class and using a forward declaration. Looking at https://trac.webkit.org/browser/webkit/trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h?rev=134346 that seems to have been how it was done previously, so I'll move to that.

>> Source/WebKit/UIProcess/WebInspectorProxy.h:221
>> +    ATOM registerWindowClass();
> 
> The original implementaion had returned bool. Why do you want to return ATOM?

I was just matching it to the actual return type for RegisterClassEx, but since we really only care about did it work or not, moving to bool should be okay.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180709/1b8839e4/attachment.html>