[Webkit-unassigned] [Bug 186690] AX: setValue on text controls should send out key events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186690

--- Comment #4 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 344249
  --> https://bugs.webkit.org/attachment.cgi?id=344249
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344249&action=review

>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1784
>> +    }
> 
> should we make the following statement an else if so this follows the rest of the pattern and we can ditch the return;

This if checks the frame. But we still want to follow the rest of the pattern if the element is not in editing mode. So I think a return here is more appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180705/bbb4fe49/attachment.html>