[Webkit-unassigned] [Bug 186690] AX: setValue on text controls should send out key events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186690

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344249|review?                     |review+
              Flags|                            |

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 344249
  --> https://bugs.webkit.org/attachment.cgi?id=344249
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344249&action=review

> Source/WebCore/ChangeLog:9
> +        Use Editor's insertText function when the text control element is being

this should be just one sentence. 

"Use the Editor's insertText function when the text control element is being, so that the InputEvent will be dispatched properly."

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1784
> +    }

should we make the following statement an else if so this follows the rest of the pattern and we can ditch the return;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180704/7b8f75af/attachment-0001.html>