[Webkit-unassigned] [Bug 182266] Should fetch owner commits in build-requests-fetcher.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 30 13:57:58 PST 2018


--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 332607
  --> https://bugs.webkit.org/attachment.cgi?id=332607

View in context: https://bugs.webkit.org/attachment.cgi?id=332607&action=review

>>> Websites/perf.webkit.org/public/include/build-requests-fetcher.php:159
>>> +                'commitOwner' => NULL,
>> We should assert that $row['commitset_commit_owner'] is NULL.
> $owner_commits_rows only contains information from commits table which does not contains 'commitset_commit_owner'

That just happens to be true for our database today. We always should be asserting those conditions in the case they change.
What's the chance you'd remember to fix this code five years from now when that condition changes?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180130/96d81b74/attachment.html>

More information about the webkit-unassigned mailing list