[Webkit-unassigned] [Bug 182266] Should fetch owner commits in build-requests-fetcher.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 30 01:54:21 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182266

--- Comment #5 from dewei_zhu at apple.com ---
Comment on attachment 332607
  --> https://bugs.webkit.org/attachment.cgi?id=332607
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332607&action=review

>> Websites/perf.webkit.org/public/include/build-requests-fetcher.php:158
>> +                'repository' => $row['commit_repository'],
> 
> Do: $resolve_ids ? $row['repository_name'] : $row['repository_id'];

Nice catch.

>> Websites/perf.webkit.org/public/include/build-requests-fetcher.php:159
>> +                'commitOwner' => NULL,
> 
> We should assert that $row['commitset_commit_owner'] is NULL.

$owner_commits_rows only contains information from commits table which does not contains 'commitset_commit_owner'

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180130/30a25cc5/attachment.html>


More information about the webkit-unassigned mailing list