[Webkit-unassigned] [Bug 181657] Support for preconnect Link headers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 15 14:57:16 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181657

--- Comment #3 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to Darin Adler from comment #2)
> Comment on attachment 331355 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331355&action=review
> 
> > Source/WebCore/loader/LinkLoader.h:68
> > +    static void preconnectIfNeeded(const LinkRelAttribute&, const URL& href, Document&, const String& crossOrigin);
> >      static std::unique_ptr<LinkPreloadResourceClient> preloadIfNeeded(const LinkRelAttribute&, const URL& href, Document&, const String& as, const String& media, const String& type, const String& crossOriginMode, LinkLoader*);
> 
> I probably would have omitted the "if needed" suffix from each of these
> function names.

The reason I added the suffix is that they only preconnect/preload if the `rel` attribute indicates that, and the check for that is inside the function. I'm happy to change that to something else or to remove the suffix entirely if you think that'd be clearer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180115/5f49a77b/attachment.html>


More information about the webkit-unassigned mailing list