[Webkit-unassigned] [Bug 181657] Support for preconnect Link headers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 15 16:05:07 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181657

--- Comment #4 from Darin Adler <darin at apple.com> ---
(In reply to Yoav Weiss from comment #3)
> (In reply to Darin Adler from comment #2)
> > > Source/WebCore/loader/LinkLoader.h:68
> > > +    static void preconnectIfNeeded(const LinkRelAttribute&, const URL& href, Document&, const String& crossOrigin);
> > >      static std::unique_ptr<LinkPreloadResourceClient> preloadIfNeeded(const LinkRelAttribute&, const URL& href, Document&, const String& as, const String& media, const String& type, const String& crossOriginMode, LinkLoader*);
> > 
> > I probably would have omitted the "if needed" suffix from each of these
> > function names.
> 
> The reason I added the suffix is that they only preconnect/preload if the
> `rel` attribute indicates that, and the check for that is inside the
> function. I'm happy to change that to something else or to remove the suffix
> entirely if you think that'd be clearer.

Yes, I was aware that the “if needed” suffix makes these function names more precise.

I am aware that the functions do work only if it’s needed, with conditions that must be met like “this rel attribute specifies a preconnect/preload”, and other conditions as well.

Despite that, I think “preconnect” is a good name for the function. Slightly less precise, but quite clear and even clearer that the longer name, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180116/3fb66f6c/attachment-0001.html>


More information about the webkit-unassigned mailing list