[Webkit-unassigned] [Bug 180978] Deadlock in GStreamer video sink during shutdown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180978

--- Comment #6 from Miguel Gomez <magomez at igalia.com> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> (In reply to Sebastian Dröge (slomo) from comment #0)
> 
> > Patch follows in a minute, but it needs some longer testing to make sure
> > this problem is solved for real. In the testcase it happens about once every
> > 24 hours.
> 
> Probably confirmed, this deadlock did not happen again

Sorry for the late reply.

Is this issue happening when accelerated compositing is disabled? Or does it happen with accelerated compositing enabled but gstreamer-gl is disabled? I ask because the patch touches the two cases but I'm not sure which is one you're trying to fix.

My bet is that this is the AC enabled non gst-gl case, cause I think with AC disabled the deadlock should not be happening. In that case, I think what we need is just to modify MediaPlayerPrivateGStreamerBase::cancelRepaint() to notify drawCondition always (as you did in your patch, but we don't need the m_drawCancelled variable) instead of just doing it for the non AC case. I think that the problem we find here is that the compositing thread has been destroyed so the gstreamer thread will never get the drawCondition notification from it, and we need to send it from the main thread prior to destroying the player.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180109/f8f92bfb/attachment.html>